*: Replace github.com/nspcc-dev/neofs-api-go/v2 module
#667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonard Lyubich <[email protected]>
It will be useful for `interface { Marshal() []byte }` implementations.
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
commented
Dec 11, 2024
| ) | ||
|
|
||
| // Decimal represents decimal number for accounting operations. | ||
| // | ||
| // Decimal is mutually compatible with github.com/nspcc-dev/neofs-api-go/v2/accounting.Decimal | ||
| // message. See ReadFromV2 / WriteToV2 methods. | ||
| // Decimal is mutually compatible with [protoaccounting.Decimal] message. See |
There was a problem hiding this comment.
suggest to drop such statements since regular user is not interested in this
cthulhu-rider
commented
Dec 11, 2024
| // See also WriteToV2. | ||
| func (d *Decimal) ReadFromV2(m accounting.Decimal) error { | ||
| *d = Decimal(m) | ||
| // See also [Decimal.ProtoMessage]. |
There was a problem hiding this comment.
and this, Client and node developers know what to use
cthulhu-rider
commented
Dec 11, 2024
| // | ||
| // See also WriteToV2. | ||
| func (d *Decimal) ReadFromV2(m accounting.Decimal) error { |
There was a problem hiding this comment.
note that temporary Deprecated mark wont work: conflicting import panic occurs
TBD Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
avoid-apigo
branch
from
ebbfb2d to
fb12af3
Compare
Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
avoid-apigo
branch
from
fb12af3 to
b14fc37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadFromV2/WriteToV2Client